-
Notifications
You must be signed in to change notification settings - Fork 6
Switch to Java 11 to use the built-in HttpClient instead of OkHttpClient #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
18bf2ba
to
07aaa35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Rethrowing InterruptedException is suspicious, but probably ok to preserve the interface signature.
Maybe class name could be improved to something like |
Thanks, much appreciated! Yes, I intended to preserve the signature. Also, exposing However, the risks include confusing the interrupt signal with an I/O issue. They are fundamentally different issues: an interrupt generally means the thread has been asked to stop what it's doing, while an We can change the API in a backwards-incompatible manner only in a major version, so it is a now or never type of decision regarding the signature of the most important method What do you think about this? Can you bring an example where handling Regarding naming: thank you, I agree, |
1daf0e4
to
0e86aa5
Compare
src/main/java/eu/webeid/security/validator/ocsp/OcspClientImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/webeid/security/validator/ocsp/OcspClientImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mart Somermaa <mrts@users.noreply.github.com>
0e86aa5
to
9293f3f
Compare
Kudos, SonarCloud Quality Gate passed!
|
WE2-790