chore: supersede strip-ansi with stripVTControlCharacters #1261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the external dependency on strip-ansi package and replaces it with Node.js built-in stripVTControlCharacters function from the node:util module. This change eliminates an external dependency by leveraging native Node.js functionality.
- Replace
strip-ansiimport withstripVTControlCharactersfromnode:util - Remove
strip-ansipackage dependency from test package.json - Maintain same functionality through aliasing
stripVTControlCharactersasstripAnsi
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/package.json | Remove strip-ansi dependency |
| tests/integration/externals/index.test.ts | Replace strip-ansi import with Node.js built-in |
| tests/integration/external-helpers/index.test.ts | Replace strip-ansi import with Node.js built-in |
| tests/integration/entry/index.test.ts | Replace strip-ansi import with Node.js built-in |
| tests/integration/dts/index.test.ts | Replace strip-ansi import with Node.js built-in |
| tests/integration/dts-tsgo/bundleFalse.test.ts | Replace strip-ansi import with Node.js built-in |
| tests/integration/config-check/index.test.ts | Replace strip-ansi import with Node.js built-in |
| tests/integration/auto-external/index.test.ts | Replace strip-ansi import with Node.js built-in |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Timeless0911
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
prefer buit-in functions.
Related Links
Checklist