-
-
Notifications
You must be signed in to change notification settings - Fork 59
feat(create-rslib): add react template and tools(storybook/vitest) #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CodSpeed Performance ReportMerging #326 will not alter performanceComparing Summary
|
2fbe0bd
to
27435cf
Compare
packages/create-rslib/fragments/tools/vitest-node-ts/package.json
Outdated
Show resolved
Hide resolved
0cc4afa
to
2d7d078
Compare
I think developers of JS projects may not want to use TypeScript |
It depends on the contents of For Storybook or Vitest, the config file might be different for Rspack, Rsbuild or Rslib. |
The PR title can be more precise🥹 |
2d7d078
to
0317131
Compare
I was wrong, I forget TS can't only check part of the file. Will remove TS check. |
0317131
to
7165d42
Compare
7165d42
to
d2443db
Compare
The generated template files are numerous and may continue to grow. We can generate these template files during the create-rslib |
Summary
Programmatically generate templates
[${template}]-[${(tools ? Object.keys(tools) : []).sort()}]-${lang}
.vitest
is applicable for all templates andstorybook
is applicable for UI related template (react).Add React template
Templates tweak
typescript
dependency anddts: true
for JS projects: Emitting dts for JS templates. It's acceptable to write non-TS project sometimes, but dts is recommended to emit and enable partial type check when needed.TODO
tools
step merge intocreate-rstack
?Related Links
Checklist