Consolidate the flake8 setup into tools/tox.ini and config files #13865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flake8 is still run as part of the "tools/ unittests (Python 2)" job in Travis, because `run_applicable_tox` in tools/ci/ci_tools_unittest.sh will turn `TOXENV=py27` into `TOXENV=py27,py27-flake8`. Splitting flake8 into a separate job entirely is left for later.
wpt-pr-bot
added
infra
tox.ini
wpt
wptrunner
jgraham
approved these changes
Nov 2, 2018
gsnedders
reviewed
Nov 2, 2018
| @@ -1,26 +1,20 @@ | |||
| [tox] | |||
| envlist = py27,py36,pypy | |||
| envlist = py27,py36,pypy,py27-flake8 | |||
There was a problem hiding this comment.
We now aren't running flake8 on py36 (and due to Py2/3 differences, there are actual differences that it does catch).
There was a problem hiding this comment.
I've proposed a fix in #13875.
foolip
added a commit
that referenced
this pull request
Nov 2, 2018
This was accidentally dropped in #13865. Splitting flake8.ini into two is a bit unfortunate, but after trimming to just the errors and warnings that are hit, they differ a bit. Unfortunately using `--append-config` twice doesn't work.
gsnedders
pushed a commit
that referenced
this pull request
Nov 5, 2018
This was accidentally dropped in #13865. Splitting flake8.ini into two is a bit unfortunate, but after trimming to just the errors and warnings that are hit, they differ a bit. Unfortunately using `--append-config` twice doesn't work.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 14, 2018
Automatic update from web-platform-testsEnable flake8 for py3 again (#13875) This was accidentally dropped in web-platform-tests/wpt#13865. Splitting flake8.ini into two is a bit unfortunate, but after trimming to just the errors and warnings that are hit, they differ a bit. Unfortunately using `--append-config` twice doesn't work. -- wpt-commits: ba70a57943fae3d69055b1c91b083e0d46d1067d wpt-pr: 13875
staktrace
pushed a commit
to staktrace/gecko
that referenced
this pull request
Nov 15, 2018
Automatic update from web-platform-testsEnable flake8 for py3 again (#13875) This was accidentally dropped in web-platform-tests/wpt#13865. Splitting flake8.ini into two is a bit unfortunate, but after trimming to just the errors and warnings that are hit, they differ a bit. Unfortunately using `--append-config` twice doesn't work. -- wpt-commits: ba70a57943fae3d69055b1c91b083e0d46d1067d wpt-pr: 13875
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
Automatic update from web-platform-testsEnable flake8 for py3 again (#13875) This was accidentally dropped in web-platform-tests/wpt#13865. Splitting flake8.ini into two is a bit unfortunate, but after trimming to just the errors and warnings that are hit, they differ a bit. Unfortunately using `--append-config` twice doesn't work. -- wpt-commits: ba70a57943fae3d69055b1c91b083e0d46d1067d wpt-pr: 13875 UltraBlame original commit: 617ea28eb87ea4ae9e183eedac5a27a180f32046
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
Automatic update from web-platform-testsEnable flake8 for py3 again (#13875) This was accidentally dropped in web-platform-tests/wpt#13865. Splitting flake8.ini into two is a bit unfortunate, but after trimming to just the errors and warnings that are hit, they differ a bit. Unfortunately using `--append-config` twice doesn't work. -- wpt-commits: ba70a57943fae3d69055b1c91b083e0d46d1067d wpt-pr: 13875 UltraBlame original commit: 617ea28eb87ea4ae9e183eedac5a27a180f32046
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
Automatic update from web-platform-testsEnable flake8 for py3 again (#13875) This was accidentally dropped in web-platform-tests/wpt#13865. Splitting flake8.ini into two is a bit unfortunate, but after trimming to just the errors and warnings that are hit, they differ a bit. Unfortunately using `--append-config` twice doesn't work. -- wpt-commits: ba70a57943fae3d69055b1c91b083e0d46d1067d wpt-pr: 13875 UltraBlame original commit: 617ea28eb87ea4ae9e183eedac5a27a180f32046
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flake8 is still run as part of the "tools/ unittests (Python 2)" job in
Travis, because
run_applicable_toxin tools/ci/ci_tools_unittest.shwill turn
TOXENV=py27intoTOXENV=py27,py27-flake8.Splitting flake8 into a separate job entirely is left for later.