Add "quic" property to manifest and add "--include-quic" switch to wptrunner #23468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
infra
manifest
wptrunner
Hexcles
commented
May 11, 2020
Hexcles
commented
May 12, 2020
--enable-quic, set to false by default. This flag also controls whether to assign a port to QUIC in the server config, which will then be passed to `wpt serve` to determine whether to start the QUIC server (to be implemented).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these two changes,
./wpt runcan skip tests that require QUIC by default, unless--include-quicis given (tested manually using--list-disabled). The flag is also plumbed all the way toTestEnvironmentand towpt serve(viaconfig). A future change inwpt servewill start the QUIC server based on this flag.Probably easier to review the two commits separately.
RFC: https://github.com/web-platform-tests/rfcs/blob/master/rfcs/quic.md
Tracking issue: #19114