HTML: set location.protocol to broken schemes #4412

annevk · 2017-01-03T14:23:37Z

wpt-pr-bot · 2017-01-03T14:23:38Z

Notifying @Ms2ger, @ayg, @gsnedders, @jdm, @jgraham, @sideshowbarker, @zcorpan, and @zqzhang. (Learn how reviewing works.)

annevk · 2017-01-03T14:24:02Z

Note: this requires some changes to the URL Standard that the HTML Standard has forever anticipated. PR coming up for that.

This is necessary to define the behavior of the Location object’s protocol attribute, which throws on syntax errors rather than silently ignoring them as other protocol setters do. Tests: web-platform-tests/wpt#4412. This is the cleanup work mentioned in whatwg/html@f0a7365 345689 that is happening way late.

This is necessary to define the behavior of the Location object’s protocol attribute, which throws on syntax errors rather than silently ignoring them as other protocol setters do. Tests: web-platform-tests/wpt#4412. This is the cleanup work mentioned in whatwg/html@f0a7365 that is happening way late.

annevk · 2017-01-03T14:38:37Z

It might be worth testing these broken schemes inside a data URL <iframe> as well and maybe an <iframe srcdoc>. So please don't land straight away.

annevk · 2017-01-03T15:02:59Z

whatwg/url#194 is the change to the URL Standard by the way. This is ready to land now.

wpt-stability-bot · 2017-01-03T15:06:02Z

Firefox

Testing revision 1765203
Starting 10 test iterations
All results were stable

All results

/html/browsers/history/the-location-interface/location-protocol-setter.html

Subtest	Results
	OK
`X%0A (percent-encoded) is not a scheme`	FAIL
`%20X (percent-encoded) is not a scheme`	FAIL
`%C3%BFx (percent-encoded) is not a scheme`	FAIL
`X%20 (percent-encoded) is not a scheme`	FAIL
`%C3%A2%E2%82%AC%C2%A0x (percent-encoded) is not a scheme`	FAIL
`x%01 (percent-encoded) is not a scheme`	FAIL
`X%00 (percent-encoded) is not a scheme`	FAIL
`%C2%80x (percent-encoded) is not a scheme`	FAIL
`%20 (percent-encoded) is not a scheme`	FAIL
`x%C3%A2%E2%82%AC%C2%A0 (percent-encoded) is not a scheme`	FAIL
`!X (percent-encoded) is not a scheme`	FAIL
`a+-.%0A (percent-encoded) is not a scheme`	FAIL
`:x (percent-encoded) is not a scheme`	FAIL
`X! (percent-encoded) is not a scheme`	FAIL
`%C3%BF (percent-encoded) is not a scheme`	FAIL
`x%0A (percent-encoded) is not a scheme`	FAIL
`x! (percent-encoded) is not a scheme`	FAIL
`%7F (percent-encoded) is not a scheme`	FAIL
`%C3%BFX (percent-encoded) is not a scheme`	FAIL
`%C2%80 (percent-encoded) is not a scheme`	FAIL
`x%C2%80 (percent-encoded) is not a scheme`	FAIL
`X%C3%A2%E2%82%AC%C2%A0 (percent-encoded) is not a scheme`	FAIL
`%C3%A2%E2%82%AC%C2%A0X (percent-encoded) is not a scheme`	FAIL
`X%01 (percent-encoded) is not a scheme`	FAIL
`x%C3%BF (percent-encoded) is not a scheme`	FAIL
`%0Ax (percent-encoded) is not a scheme`	FAIL
`!x (percent-encoded) is not a scheme`	FAIL
`%01x (percent-encoded) is not a scheme`	FAIL
`: (percent-encoded) is not a scheme`	FAIL
`%7FX (percent-encoded) is not a scheme`	FAIL
`! (percent-encoded) is not a scheme`	FAIL
`%20x (percent-encoded) is not a scheme`	FAIL
`a%0A (percent-encoded) is not a scheme`	FAIL
`%0AX (percent-encoded) is not a scheme`	FAIL
`X%7F (percent-encoded) is not a scheme`	FAIL
`%00x (percent-encoded) is not a scheme`	FAIL
`x%00 (percent-encoded) is not a scheme`	FAIL
`Equivalent tests for data URL and srcdoc <iframe>s`	FAIL
`%00 (percent-encoded) is not a scheme`	FAIL
`%0A (percent-encoded) is not a scheme`	FAIL
`%01X (percent-encoded) is not a scheme`	FAIL
`x%20 (percent-encoded) is not a scheme`	FAIL
`%C3%A2%E2%82%AC%C2%A0 (percent-encoded) is not a scheme`	FAIL
`%7Fx (percent-encoded) is not a scheme`	FAIL
`X%C2%80 (percent-encoded) is not a scheme`	FAIL
`%C2%80X (percent-encoded) is not a scheme`	FAIL
`X%C3%BF (percent-encoded) is not a scheme`	FAIL
`%01 (percent-encoded) is not a scheme`	FAIL
`x%7F (percent-encoded) is not a scheme`	FAIL
`%00X (percent-encoded) is not a scheme`	FAIL
`:X (percent-encoded) is not a scheme`	FAIL

wpt-stability-bot · 2017-01-03T15:09:28Z

Chrome

Testing revision 1765203
Starting 10 test iterations
All results were stable

All results

/html/browsers/history/the-location-interface/location-protocol-setter.html

Subtest	Results
	OK
`X%0A (percent-encoded) is not a scheme`	PASS
`%20X (percent-encoded) is not a scheme`	PASS
`x%E2%80%A0 (percent-encoded) is not a scheme`	PASS
`%C3%BFx (percent-encoded) is not a scheme`	PASS
`X%20 (percent-encoded) is not a scheme`	PASS
`x%01 (percent-encoded) is not a scheme`	PASS
`X%00 (percent-encoded) is not a scheme`	PASS
`%C2%80x (percent-encoded) is not a scheme`	PASS
`%20 (percent-encoded) is not a scheme`	PASS
`%E2%80%A0 (percent-encoded) is not a scheme`	PASS
`!X (percent-encoded) is not a scheme`	PASS
`a+-.%0A (percent-encoded) is not a scheme`	PASS
`:x (percent-encoded) is not a scheme`	PASS
`X! (percent-encoded) is not a scheme`	PASS
`x%0A (percent-encoded) is not a scheme`	PASS
`x! (percent-encoded) is not a scheme`	PASS
`%7F (percent-encoded) is not a scheme`	PASS
`%C3%BFX (percent-encoded) is not a scheme`	PASS
`%C2%80 (percent-encoded) is not a scheme`	PASS
`x%C2%80 (percent-encoded) is not a scheme`	PASS
`X%01 (percent-encoded) is not a scheme`	PASS
`x%C3%BF (percent-encoded) is not a scheme`	PASS
`%0Ax (percent-encoded) is not a scheme`	PASS
`!x (percent-encoded) is not a scheme`	PASS
`%01x (percent-encoded) is not a scheme`	PASS
`: (percent-encoded) is not a scheme`	PASS
`%7FX (percent-encoded) is not a scheme`	PASS
`! (percent-encoded) is not a scheme`	PASS
`%20x (percent-encoded) is not a scheme`	PASS
`a%0A (percent-encoded) is not a scheme`	PASS
`%0AX (percent-encoded) is not a scheme`	PASS
`%E2%80%A0X (percent-encoded) is not a scheme`	PASS
`X%7F (percent-encoded) is not a scheme`	PASS
`%00x (percent-encoded) is not a scheme`	PASS
`X%E2%80%A0 (percent-encoded) is not a scheme`	PASS
`x%00 (percent-encoded) is not a scheme`	PASS
`Equivalent tests for data URL and srcdoc <iframe>s`	PASS
`%00 (percent-encoded) is not a scheme`	PASS
`%0A (percent-encoded) is not a scheme`	PASS
`%01X (percent-encoded) is not a scheme`	PASS
`x%20 (percent-encoded) is not a scheme`	PASS
`%C3%BF (percent-encoded) is not a scheme`	PASS
`%7Fx (percent-encoded) is not a scheme`	PASS
`X%C2%80 (percent-encoded) is not a scheme`	PASS
`%C2%80X (percent-encoded) is not a scheme`	PASS
`X%C3%BF (percent-encoded) is not a scheme`	PASS
`%01 (percent-encoded) is not a scheme`	PASS
`%E2%80%A0x (percent-encoded) is not a scheme`	PASS
`x%7F (percent-encoded) is not a scheme`	PASS
`%00X (percent-encoded) is not a scheme`	PASS
`:X (percent-encoded) is not a scheme`	PASS

domenic · 2017-01-03T19:59:24Z

These all fail in Chrome and Firefox because of the exception type, right? I think we should change it to SyntaxError DOMException in the tests and spec before merging; no need to churn browsers over this detail.

annevk · 2017-01-04T08:29:51Z

Well Firefox needs a change anyway since it's not "SyntaxError" there but rather some internal thing. I guess we can decide to align with Chrome, but it seems a little weird since we use TypeError normally for URL parsing issues.

See whatwg/url#61 for context. #4412 tests broken schemes.

domenic · 2017-01-04T19:08:37Z

Hmm. Edge also has a weird Error instead of any normal error type. Safari matches Chrome though. I guess I do not feel strongly, but I do note the following places that use "SyntaxError" DOMExceptions for URL parsing failures:

location.assign/location.replace
registerProtocolHandler/registerContentHandler
EventSource constructor
WebSocket constructor
window.postMessage origin parser
Worker/SharedWorker constructor
importScripts

annevk · 2017-01-04T19:10:45Z

Okay, I will give up, but not today, dinner time!

This matches Chrome and Safari. Edge and Firefox use an internal error that needs to change either way. Tests: web-platform-tests/wpt#4412. Additional context: whatwg/url#61.

annevk · 2017-01-05T11:05:48Z

This is now ready to land.

This matches Blink and WebKit. Edge and Gecko use an internal error that needs to change either way. Tests: web-platform-tests/wpt#4412. Additional context: whatwg/url#61.

This is necessary to define the behavior of the Location object’s protocol attribute, which throws on syntax errors rather than silently ignoring them as other protocol setters do. Tests: web-platform-tests/wpt#4412. This is the cleanup work mentioned in whatwg/html@f0a7365 that is happening way late.

See whatwg/url#61 for context. #4412 tests broken schemes.

This matches Blink and WebKit. Edge and Gecko use an internal error that needs to change either way. Tests: web-platform-tests/wpt#4412. Additional context: whatwg/url#61.

HTML: set location.protocol to broken schemes

764b480

See whatwg/url#61 for context.

wpt-pr-bot added the html label Jan 3, 2017

annevk mentioned this pull request Jan 3, 2017

Return failure in state override scheme parsing whatwg/url#194

Merged

bonus material

e4ae671

test more broken schemes

ec736ff

annevk added a commit that referenced this pull request Jan 4, 2017

HTML: set location.protocol to non-broken-non-functioning schemes

9fcd9c8

See whatwg/url#61 for context. #4412 tests broken schemes.

annevk mentioned this pull request Jan 4, 2017

HTML: set location.protocol to non-broken-non-functioning schemes #4502

Merged

annevk added the do not merge yet label Jan 4, 2017

use DOMException

39e7996

annevk mentioned this pull request Jan 5, 2017

Use "SyntaxError" for location.protocol's setter whatwg/html#2245

Merged

annevk removed the do not merge yet label Jan 5, 2017

domenic merged commit 6ab8b20 into master Jan 5, 2017

domenic deleted the annevk/location-protocol-broken branch January 5, 2017 14:41

annevk added a commit that referenced this pull request Jan 5, 2017

HTML: set location.protocol to non-broken-non-functioning schemes

45869bb

See whatwg/url#61 for context. #4412 tests broken schemes.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HTML: set location.protocol to broken schemes #4412

HTML: set location.protocol to broken schemes #4412

annevk commented Jan 3, 2017

wpt-pr-bot commented Jan 3, 2017

annevk commented Jan 3, 2017

annevk commented Jan 3, 2017

annevk commented Jan 3, 2017

wpt-stability-bot commented Jan 3, 2017 •

edited

Loading

wpt-stability-bot commented Jan 3, 2017 •

edited

Loading

domenic commented Jan 3, 2017

annevk commented Jan 4, 2017

domenic commented Jan 4, 2017

annevk commented Jan 4, 2017

annevk commented Jan 5, 2017

HTML: set location.protocol to broken schemes #4412

HTML: set location.protocol to broken schemes #4412

Conversation

annevk commented Jan 3, 2017

wpt-pr-bot commented Jan 3, 2017

annevk commented Jan 3, 2017

annevk commented Jan 3, 2017

annevk commented Jan 3, 2017

wpt-stability-bot commented Jan 3, 2017 • edited Loading

Firefox

All results

wpt-stability-bot commented Jan 3, 2017 • edited Loading

Chrome

All results

domenic commented Jan 3, 2017

annevk commented Jan 4, 2017

domenic commented Jan 4, 2017

annevk commented Jan 4, 2017

annevk commented Jan 5, 2017

wpt-stability-bot commented Jan 3, 2017 •

edited

Loading

wpt-stability-bot commented Jan 3, 2017 •

edited

Loading