HTML: set location.protocol to non-broken-non-functioning schemes #4502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See whatwg/url#61 for context. #4412 tests broken schemes.
|
Notifying @Ms2ger, @ayg, @gsnedders, @jdm, @jgraham, @sideshowbarker, @zcorpan, and @zqzhang. (Learn how reviewing works.) |
|
The -weird.html is an earlier iteration of the test (excluding data URL tests) that for some reason never completes running in Firefox. I thought I'd include it since it does show differences between the two ways of testing. |
FirefoxTesting revision 4c31b59 All results/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html
/html/browsers/history/the-location-interface/location-protocol-setter-non-broken-weird.html
|
ChromeTesting revision 4c31b59 All results/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html
/html/browsers/history/the-location-interface/location-protocol-setter-non-broken-weird.html
|
zcorpan
requested changes
Jan 4, 2017
| 'http+x' | ||
| ].forEach((val, index) => { | ||
| async_test((t) => { | ||
| try { |
There was a problem hiding this comment.
Remove try/catch; testharness.js will catch the exception.
| const frame = document.createElement("iframe") | ||
| frame.src = "resources/dummy.html" | ||
| frame.onload = t.step_func(() => { | ||
| try { |
| assert_unreached(e) | ||
| } | ||
| }) | ||
| }) |
|
Thanks, pushed fixes. |
zcorpan
approved these changes
Jan 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/url#61 for context.
#4412 tests broken
schemes.