Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getContext()'s second argument #9194

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@annevk
Copy link
Member

annevk commented Jan 25, 2018

See whatwg/html#595 and whatwg/html#3370 for context.

annevk added some commits Jan 25, 2018

more clearly indicate where these tests originate (needed in particul…
…ar for those stuffed in /html/ somewhere)

@annevk annevk requested a review from gsnedders Jan 25, 2018

annevk added a commit to whatwg/html that referenced this pull request Jan 25, 2018

Simplify getContext() and make it throw less
In practice getContext() only has two arguments. And in practice some
handling of the second argument is shared across the various rendering
context types. This aligns the standard with that practice.

This also obviates the need for dedicated coercion algorithms for "2d"
and "bitmaprender".

This change also fixes various minor nits found along the way, such as
the inconsistent spelling of contextId (was sometimes contextType).

Tests: web-platform-tests/wpt#9194.

Fixes #595.
@tobie

This comment has been minimized.

Copy link
Contributor

tobie commented Jan 25, 2018

Summoning @wpt-pr-bot.

@annevk

This comment has been minimized.

Copy link
Member Author

annevk commented Jan 25, 2018

Someone else will have to run update-built-tests.sh since I'm not super keen on installing virtualenv and such.

annevk added a commit to whatwg/html that referenced this pull request Jan 26, 2018

Simplify getContext() and make it throw less
In practice getContext() only has two arguments. And in practice some
handling of the second argument is shared across the various rendering
context types. This aligns the standard with that practice.

This also obviates the need for dedicated coercion algorithms for "2d"
and "bitmaprender".

This change also fixes various minor nits found along the way, such as
the inconsistent spelling of contextId (was sometimes contextType).

Tests: web-platform-tests/wpt#9194 and
web-platform-tests/wpt#9205.

Fixes #595.

alice added a commit to alice/html that referenced this pull request Jan 8, 2019

Simplify getContext() and make it throw less
In practice getContext() only has two arguments. And in practice some
handling of the second argument is shared across the various rendering
context types. This aligns the standard with that practice.

This also obviates the need for dedicated coercion algorithms for "2d"
and "bitmaprender".

This change also fixes various minor nits found along the way, such as
the inconsistent spelling of contextId (was sometimes contextType).

Tests: web-platform-tests/wpt#9194 and
web-platform-tests/wpt#9205.

Fixes whatwg#595.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.