Fix Idagio connector

[LibertyFrog]

Describe the changes you made
Fixed the Idagio connector not recognizing when a track is playing.

Additional context
The Idagio connector was not scrobbling music. The isPlaying check expects the play button label to equal "Pause" when a track is playing which is also what is visible in the DOM, however they use a text-transform: uppercase CSS styling on it.
I call toUpper on the found text, so it doesn't break again should they remove the styling.

[hornbuckle]

If the text inside the element is "Pause," CSS text-transform shouldn't have any effect on the connector script since it would only affect how the browser renders the text.
Can you provide a link to show the issue you're trying to fix?

[LibertyFrog]

If the text inside the element is "Pause," CSS text-transform shouldn't have any effect on the connector script since it would only affect how the browser renders the text. Can you provide a link to show the issue you're trying to fix?

That is not the behaviour I'm observing. As for a link: go to https://app.idagio.com and click the play icon on any album tile. When I do it the extension doesn't start scrobbling and when I look at the State object I see the isPlaying property is still false.

This is what I see in the DOM for the pause button selector, "Pause":

This is the CSS applying the text-transform:

I added logging to the isPlaying getter (without the toUpper I added later):

This is the log output, all uppercase "PAUSE":

This is the log output after toggling text-transform in the browser dev tools (no other change):

[hornbuckle]

Thank you for providing that explanation with screenshots too! It's odd that they would even apply text-transform to an element that isn't actually visible. But now I see the reason why it is behaving this way: getTextFromSelectors function is using innerText which, unlike textContent, is aware of any styling applied to the element. Even though the element isn't visible to a user, it's still technically being displayed in the browser and inheriting the text-transform styling applied to it.

[hornbuckle]

While it's being updated, one other note on this particular connector to prevent future breakage is that the random characters in the classes may change when an update is pushed to the site, so it would be advisable to target them a bit different. For example, .player-PlayerInfo__recordingInfo--15VMv should be targeted as [class^=player-PlayerInfo__recordingInfo--] so it will still work even if those random characters on the end change. (See the Mixcloud connector, for example: https://github.com/web-scrobbler/web-scrobbler/blob/master/src/connectors/mixcloud.ts )

[inverse]

Any updates on this one?

[yayuyokitano]

Merging this. Improvement suggested by hornbuckle can be applied in a separate PR.