Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/giant-taxis-breathe.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@web-std/fetch": patch
---

Memory leak caused by unregistered listeners. Solution was copied from a node-fetch pr.
22 changes: 14 additions & 8 deletions packages/fetch/src/fetch.js
Original file line number Diff line number Diff line change
Expand Up @@ -346,13 +346,8 @@ function fixResponseChunkedTransferBadEnding(request, errorCallback) {
}
};

socket.prependListener('close', onSocketClose);

request.on('abort', () => {
socket.removeListener('close', onSocketClose);
});

socket.on('data', buf => {
/** @param {Buffer} buf */
const onData = buf => {
properLastChunkReceived = Buffer.compare(buf.slice(-5), LAST_CHUNK) === 0;

// Sometimes final 0-length chunk and end of message code are in separate packets
Expand All @@ -364,7 +359,18 @@ function fixResponseChunkedTransferBadEnding(request, errorCallback) {
}

previousChunk = buf;
});
};

socket.prependListener('close', onSocketClose);
socket.on('data', onData);

const removeSocketListeners = () => {
socket.removeListener('close', onSocketClose);
socket.removeListener('data', onData);
}

request.on('close', removeSocketListeners);
request.on('abort', removeSocketListeners);
});
}

Expand Down