Skip to content

Conversation

unixslayer
Copy link

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0002%) to 0.043% when pulling 6991f52 on unixslayer:master into 7b61ef7 on web-token:master.

@Spomky
Copy link
Member

Spomky commented Sep 5, 2019

Thank you. That's a nice addition!
It looks like I forgot this use case.

@Spomky Spomky self-assigned this Sep 5, 2019
@Spomky Spomky added the feature label Sep 5, 2019
@Spomky Spomky added this to the v2.1 milestone Sep 5, 2019
@Spomky Spomky changed the base branch from master to v2.1 September 5, 2019 19:16
@Spomky Spomky changed the base branch from v2.1 to master September 5, 2019 19:17
@unixslayer
Copy link
Author

@Spomky about this PR, should I bother with Travis and coveralls? Travis fails because of core code which wasn't changed in PR. Also coverage decrease seems irrelevant with 0.043% ;)

@Spomky
Copy link
Member

Spomky commented Sep 6, 2019

Don't worry about the failing tests. I will soon close this PR, but integrate it in the v2.1 branch (the branch master is not appropriate for this new feature).

@unixslayer unixslayer changed the base branch from master to v2.1 September 6, 2019 11:08
@unixslayer
Copy link
Author

@Spomky I think I've messed up something when changing base branch. Will do this PR again this time from proper branch.

@unixslayer unixslayer closed this Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants