Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaking XMLHttpRequest into the global scope #844

Closed
fabioberger opened this issue Mar 28, 2017 · 4 comments
Closed

Leaking XMLHttpRequest into the global scope #844

fabioberger opened this issue Mar 28, 2017 · 4 comments
Assignees
@nivida

Comments

@fabioberger
Copy link

fabioberger commented Mar 28, 2017 •
edited
Loading

Current behavior:
After requiring web3, global.XMLHttpRequest is defined. Before the require it wasn't.

Expected behavior:
Requiring web3 should not add properties to the global scope.

Affecting other projects that use web3: https://github.com/trufflesuite/truffle-contract/issues/14
@LogvinovLeon
Copy link
Contributor

+1

@fabioberger
Copy link
Author

Any update on this @frozeman? Still running into this issue often.

@fabioberger fabioberger mentioned this issue Feb 2, 2018
Closed
@fabioberger fabioberger mentioned this issue Jul 3, 2018
Merged
8 tasks
@nivida nivida self-assigned this Aug 9, 2018
@nivida
Copy link
Contributor

nivida commented Nov 29, 2018

This shoud be fixed with the PR #2000

@nivida
Copy link
Contributor

nivida commented Apr 2, 2019

This got fixed with the ProvidersModuleFactory.

@nivida nivida closed this as completed Apr 2, 2019
@alcuadrado alcuadrado mentioned this issue Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nivida nivida

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nivida @fabioberger @LogvinovLeon