Remote node provider edits #3884
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 662507808
💛 - Coveralls |
spacesailor24
approved these changes
Feb 1, 2021
spacesailor24
suggested changes
Feb 1, 2021
|
Just updated the changelog.md - please let me know if there are any issues! Thanks.
[https://my-email-signature.link/signature.gif?u=1100946&e=134171491&v=c1f68f389579debc3b7bb1a3c5b1f2de50574b2a32ca54571622388bcbaa7c0f]
…________________________________
From: Wyatt Barnes <notifications@github.com>
Sent: Monday, February 1, 2021 9:50 AM
To: ChainSafe/web3.js <web3.js@noreply.github.com>
Cc: Sumi Pal Mudgil <smudgil@stanford.edu>; Author <author@noreply.github.com>
Subject: Re: [ChainSafe/web3.js] Remote node provider edits (#3884)
@spacesailor24 requested changes on this pull request.
Can you update the CHANGELOG.md? Other than that, this should be good to go, thank you for opening the PR
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#3884 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJDNA63NDEAN2R2ZNHB7AHLS425UXANCNFSM4WSUESZQ>.
|
|
Thank you for the response, doesn't look like the CHANGELOG change made it to this PR, could you try pushing again? |
Closed
koraykoska
previously approved these changes
Feb 10, 2021
|
Hi there! Just wanted to follow up on the status of this :) |
|
Sorry that this hung around for so long, can you solve the merge conflicts, then this can be merged |
spacesailor24
added
Changes Requested
|
Just solved, lmk if you have any questions!
[https://my-email-signature.link/signature.gif?u=1100946&e=140335693&v=fc9174b9170616d34aabd7c04989a926f6ba434b5f82d63e43a2774beb1bd760]
…________________________________
From: Wyatt Barnes <notifications@github.com>
Sent: Tuesday, March 9, 2021 6:14 PM
To: ChainSafe/web3.js <web3.js@noreply.github.com>
Cc: Sumi Pal Mudgil <smudgil@stanford.edu>; Author <author@noreply.github.com>
Subject: Re: [ChainSafe/web3.js] Remote node provider edits (#3884)
Sorry that this hung around for so long, can you solve the merge conflicts, then this can be merged
Thank you!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#3884 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJDNA67PGAK3S3UXPP6GZOTTC2MVLANCNFSM4WSUESZQ>.
|
spacesailor24
previously approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited the documentation to include how to use web3 with a remote node provider.
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.