Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1.6.1. bundle size growth #4501

Merged
merged 3 commits into from
Oct 26, 2021
Merged

Conversation

nazarhussain
Copy link
Contributor

Description

  1. Updated to latest dependecnies
  2. Removed unused dependencies
  3. Update the build configuration to avoid including static large files

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

Copy link
Contributor

@spacesailor24 spacesailor24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think tests are going to run since it's not merging into 1.x

@spacesailor24 spacesailor24 merged commit 6391f7d into release/1.6.1 Oct 26, 2021
@spacesailor24 spacesailor24 deleted the nh/build-size-fixes-1.6.1 branch October 26, 2021 20:33
spacesailor24 added a commit that referenced this pull request Nov 15, 2021
* Build for 1.6.1-rc.0

* v1.6.1-rc.0

* Manual commit for v1.6.1-rc.0 dist build

* Manual build for 1.6.1-rc.1

* v1.6.1-rc.1

* Fix 1.6.1. bundle size growth (#4501)

* ➖ Remove unused dependency

* ⬆️ Update dependencies

* 👷 Update webpack config to exclude static json files

* npm i and manual build for 1.6.1-rc.2

* Debug CI tests

* Debug CI tests

* Debug CI tests

* Fix 1.6.1 build size issue with removing static asset files (#4506)

* 👷 Update the build configurations

* 🔧 Update karma configuraiton to remove uninteded config

* 🎨 Update build steps to minimize build size

* 🎨 Update build config

* npm i and npm run build for 1.6.1-rc.2

* Update CHANGELOG

* v1.6.1-rc.2

* Manual build commit for 1.6.2-rc.2

* Improve timeout handling for the block polling for confirmation  (#4527)

* 🎨 Improve the block header timeout handling

* Update comment web3.rst (#4511)

* Update comment web3.rst

* updating changelog

Co-authored-by: Alex <alex.luu@mail.utoronto.ca>

Co-authored-by: Anh Hong <hong4rc@gmail.com>
Co-authored-by: Alex <alex.luu@mail.utoronto.ca>

* npm i

* Update CHANGELOG

* Build for 1.6.1-rc.3

* v1.6.1-rc.3

* Build for 1.6.1-rc.3

* npm i

* v1.6.1

* Manual commit for 1.6.1

Co-authored-by: Nazar Hussain <nazarhussain@gmail.com>
Co-authored-by: Anh Hong <hong4rc@gmail.com>
Co-authored-by: Alex <alex.luu@mail.utoronto.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants