Improve timeout handling for the block polling for confirmation #4527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update comment web3.rst * updating changelog Co-authored-by: Alex <alex.luu@mail.utoronto.ca>
|
Your Render PR Server URL is https://web3-js-pr-4527.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c65ce89t9ds951ks07lg. |
spacesailor24
approved these changes
Nov 9, 2021
|
lgtm, except one thing: gnosis_dex tests not passing here. |
spacesailor24
added a commit
that referenced
this pull request
Nov 15, 2021
* Build for 1.6.1-rc.0 * v1.6.1-rc.0 * Manual commit for v1.6.1-rc.0 dist build * Manual build for 1.6.1-rc.1 * v1.6.1-rc.1 * Fix 1.6.1. bundle size growth (#4501) * ➖ Remove unused dependency * ⬆️ Update dependencies * 👷 Update webpack config to exclude static json files * npm i and manual build for 1.6.1-rc.2 * Debug CI tests * Debug CI tests * Debug CI tests * Fix 1.6.1 build size issue with removing static asset files (#4506) * 👷 Update the build configurations * 🔧 Update karma configuraiton to remove uninteded config * 🎨 Update build steps to minimize build size * 🎨 Update build config * npm i and npm run build for 1.6.1-rc.2 * Update CHANGELOG * v1.6.1-rc.2 * Manual build commit for 1.6.2-rc.2 * Improve timeout handling for the block polling for confirmation (#4527) * 🎨 Improve the block header timeout handling * Update comment web3.rst (#4511) * Update comment web3.rst * updating changelog Co-authored-by: Alex <alex.luu@mail.utoronto.ca> Co-authored-by: Anh Hong <hong4rc@gmail.com> Co-authored-by: Alex <alex.luu@mail.utoronto.ca> * npm i * Update CHANGELOG * Build for 1.6.1-rc.3 * v1.6.1-rc.3 * Build for 1.6.1-rc.3 * npm i * v1.6.1 * Manual commit for 1.6.1 Co-authored-by: Nazar Hussain <nazarhussain@gmail.com> Co-authored-by: Anh Hong <hong4rc@gmail.com> Co-authored-by: Alex <alex.luu@mail.utoronto.ca>
This was referenced Jan 12, 2022
This was referenced Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve the timeout handling to cover one edge case.
Fixes #4526
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.