-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spanishfood.about.com - mobile site is not usable, due to Modernizr.csstransform3d false positive #2151
Comments
Note, this doesn't reproduce with |
I see the following Modernizr class: |
Possibly related, note $(function() {
function a() {
var a = $(".fixed-social");
e.toggleClass(j),
d.toggleClass(i),
f.toggleClass(k),
g.toggleClass(l),
a.length && (e.hasClass(j) ? a.addClass(k) : a.removeClass(k))
}
function b() {
var a = $(".fixed-social");
e.addClass(j),
d.animate({
left: "0px"
}, n),
f.animate({
left: o
}, n),
a.length && a.animate({
left: o
}, n),
g.animate({
left: o
}, n)
}
function c() {
var a = $(".fixed-social");
e.removeClass(j),
d.animate({
left: "-" + o
}, n),
f.animate({
left: "0px"
}, n),
a.length && a.animate({
left: "0px"
}, n),
g.animate({
left: "0px"
}, n)
}
var d = $(".pushy")
, e = $("body")
, f = $("#container")
, g = $(".push")
, h = $(".site-overlay")
, i = "pushy-left pushy-open"
, j = "pushy-active"
, k = "container-push"
, l = "push-push"
, m = $(".menu-btn")
, n = 200
, o = d.width() + "px";
if (Modernizr.csstransforms3d)
m.click(function(b) {
b.preventDefault(),
a()
}),
h.click(function(b) {
b.preventDefault(),
a()
});
else {
d.css({
left: "-" + o
}),
f.css({
"overflow-x": "hidden"
});
var p = !0;
m.click(function(a) {
a.preventDefault(),
p ? (b(),
p = !1) : (c(),
p = !0)
}),
h.click(function(a) {
a.preventDefault(),
p ? (b(),
p = !1) : (c(),
p = !0)
})
}
}); |
I'm like 90% certain the reason this page is busted is due to the faulty Modernizr test. Here's the code that should be working, which is responsible for translating the page/menu:
|
Current version of the Pushy lib don't have the Modernizr dependency, so that's good: christophery/pushy#39 (and the demo works fine in Nightly). |
So they're using Modernizr 2.8.3 @ http://fj.about.com/js/1.63.2/cache/eNp1kM8OwjAIxl9I14cwxusOi_f-YRXXQtNSt_n09mDiYrYLyccP-ADLMTEBSVEORl2DKMMz5BY5Qtbkz25MA0YkrxwWUU12PkkX2HvIndX2Ae70_PUHNOoF5DgryzwhlH9aBQPKDtCGq_Taw5Ukr8Oa4LDijjBv4YHVd5HIDjLhO19qEY67U2_9sM0TzCWASPtFu9BOhhcoH7Arc8M.min.js y.csstransforms3d = function() {
var a = !!i("perspective");
return a && "webkitPerspective" in p.style && B("@media (transform-3d),(-webkit-transform-3d){#modernizr{left:9px;position:absolute;height:3px;}}", function(b, c) {
a = 9 === b.offsetLeft && 3 === b.offsetHeight
}),
a
} So why is that test failing.... (Note it's a notoriously bad test Modernizr/Modernizr#590) |
Oh, right. In the |
@hallvors can you verify that this is fixed in today's nightly? |
Working on Android in the latest nightly (47.0a1 2016-01-25) |
URL: http://spanishfood.about.com/od/maincourses/r/arrozalhorno.htm
Browser / Version: Firefox Mobile 46.0
Operating System: Android 5.1.1
Problem type: Mobile site is not usable
Steps to Reproduce
Expected Behavior: page displays properly
Actual Behavior: menu blocks most of page
The text was updated successfully, but these errors were encountered: