Use the loadEvent object to provide arbitrary $.get settings #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jQuery AJAX API is pretty powerful. Rather than trying to wrap all of its abilities, for questionable gain, we can just use the load event object as the settings parameter. This lets downstream users override arbitrary settings, like `headers` or `cache` or `timeout`. The downside is if people are storing funky, non-url things in the load event, this will break their use case. But it's kind of a weird thing to do in the current IAS interface, so we probably don't have to be too paranoid about backwards compatibility. For people who only use event.url, or don't use the event object at all, they won't even know anything changed.
This was referenced Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #248
Many thanks to @campadrenalin 🙏