Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom template error #28

Closed
belerweb opened this issue Aug 25, 2012 · 1 comment
Closed

Custom template error #28

belerweb opened this issue Aug 25, 2012 · 1 comment

Comments

@belerweb
Copy link
Contributor

Consider a new template template-dashboard-itisbi.html, the content as flows:

<html>
    <head></head>
    <body>{content}</body>
</html>

CdfContentGenerator output:
1 head end tag miss "<"

/head>

2 body start tag miss ">"

<body
@belerweb
Copy link
Contributor Author

Bug from org.pentaho.cdf.CdfContentGenerator.renderHtmlDashboard method.
Error code:

        out.write(intro.substring(0, headIndex + 6).getBytes("UTF-8"));
        // Concat libraries to html head content
        getHeaders(dashboardContent, requestParams, out);
        out.write(intro.substring(headIndex + 7, length - 1).getBytes("UTF-8"));

Should be:

        out.write(intro.substring(0, headIndex + 6).getBytes("UTF-8"));
        // Concat libraries to html head content
        getHeaders(dashboardContent, requestParams, out);
        out.write(intro.substring(headIndex + 6, length).getBytes("UTF-8"));

@belerweb belerweb mentioned this issue Aug 26, 2012
Merged
pamval added a commit that referenced this issue Sep 4, 2012
@pamval
Merge pull request #30 from belerweb/patch-1
af4f9bd 
Fix #28 (Custom template error)
pamval pushed a commit that referenced this issue Sep 5, 2012
@belerweb @webdetails-build-bot
Update bi-platform-v2-plugin/src/org/pentaho/cdf/CdfContentGenerator.…
5133956 
…java

Fix issue #28.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@belerweb