Skip to content

Feature/6935 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Feature/6935 #7

merged 2 commits into from
Jun 26, 2023

Conversation

zz358840
Copy link
Contributor

Description

redmine issue

Motivation and Context

支援跑馬燈
我直接從 marty 的 pythonCode repo 新增 webbit.py 到這裡
沒有做 format code
沒有 check 其他功能
image.py 的修改沒有影響之前開發的顯示文字和圖形,但用法沒有統一

顯示圖形用法:

wbit.matrix(100, 100, 100, get_image('A'))

顯示跑馬燈用法:

wbit.scroll(10, 10, 10, 'test')
wbit.scroll(10, 10, 10, ['happy','cry'])

沒統一的原因是我不想改到底層的 matrix function

跑馬燈是另外新增的 function

How Has This Been Tested?

請看票的 prompt

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zz358840 zz358840 requested review from o4c and GoGoPenguin June 21, 2023 11:02
@zz358840 zz358840 self-assigned this Jun 21, 2023

class Temp():
def __init__(self):
self.voltagePower = 3.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python 是 snake_case

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你是說這都是直接複製過來的,是嗎?

Copy link
Contributor Author

@zz358840 zz358840 Jun 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是,webbit.py 這隻檔案就不要刁了吧,我不太想動到這隻,哪天 marty 改 code 又要花時間處理衝突

可以從這個 commit 看就好

@GoGoPenguin GoGoPenguin merged commit 3e4878d into production Jun 26, 2023
@GoGoPenguin GoGoPenguin deleted the feature/6935 branch June 26, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants