Skip to content

Display content from threads in files widget #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 23, 2021

Conversation

adamweeks
Copy link
Collaborator

Files widget wasn't updated with the proper area to find convo activities after the thread feature was added.

https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-212342

@adamweeks adamweeks requested a review from a team as a code owner March 18, 2021 16:17
@@ -21,6 +21,8 @@ import {filterActivities, normalizeActivities, normalizeActivity} from './helper

export const initialState = fromJS({
activities: new OrderedMap(),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably remove this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@adamweeks adamweeks force-pushed the fix-files-widget-threading branch from 30426c9 to cd27b82 Compare March 18, 2021 17:25
Copy link
Contributor

@taymoork2 taymoork2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image
image

@taymoork2 taymoork2 merged commit 8d62ed8 into webex:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants