-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add-faker-integration: removed 'name' because it is an existing faker option #22
add-faker-integration: removed 'name' because it is an existing faker option #22
Conversation
I think the decreased coverage check is not correct.. |
* configuration for method which are not part of faker itself | ||
* configuration for method which are not part of faker itself. | ||
* You can implement a new method "methodName" which returns for example a | ||
* format: 'suffix' => 'methodName', | ||
* @var array | ||
*/ | ||
private $replacementOptions = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we remove this as well?
Sorry @franziskahahn, I somehow lost sight of this. I only quickly skimmed As we haven't had a release since your initial contribution, I see no Problem in removing stuff. |
Hey @mpdude |
2 similar comments
I removed the config array |
Danke @franziskahahn! |
Hey guys,
I saw that "name" is already (is it new, I never saw it before?! :D) an "official" faker formatter.
So I deleted the self-written formatter.
I decided to keep the configuration skeleton because I am sure we will need individual stuff in the further development of slimdump.