-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSH config cleanup not done #184
Comments
@kcarlson would this workaround also work when multiple keys are provided? |
I've only tested it with a single key being provided to the |
`setup-git-redirect.sh` is needed for tests, because go needs SSH authentication, when downloading modules dependencies. The redirect script, though, does not revert the global changes done to the git config (in that case: SSH instead of HTTPS). The `checkout` action, on the other hand, needs the HTTPS for checkout, because the SSH key at the beginning of the action is no longer available, it was properly cleaned up in the `webfactory/ssh-agent` post clean up. Implementing workaround as in webfactory/ssh-agent#184
`setup-git-redirect.sh` is needed for tests, because go needs SSH authentication, when downloading modules dependencies. The redirect script, though, does not revert the global changes done to the git config (in that case: SSH instead of HTTPS). The `checkout` action, on the other hand, needs the HTTPS for checkout, because the SSH key at the beginning of the action is no longer available, it was properly cleaned up in the `webfactory/ssh-agent` post clean up. Implementing workaround as in webfactory/ssh-agent#184
`setup-git-redirect.sh` is needed for tests, because go needs SSH authentication, when downloading modules dependencies. The redirect script, though, does not revert the global changes done to the git config (in that case: SSH instead of HTTPS). The `checkout` action, on the other hand, needs the HTTPS for checkout, because the SSH key at the beginning of the action is no longer available, it was properly cleaned up in the `webfactory/ssh-agent` post clean up. Implementing workaround as in webfactory/ssh-agent#184
`setup-git-redirect.sh` is needed for tests, because go needs SSH authentication, when downloading modules dependencies. The redirect script, though, does not revert the global changes done to the git config (in that case: SSH instead of HTTPS). The `checkout` action, on the other hand, needs the HTTPS for checkout, because the SSH key at the beginning of the action is no longer available, it was properly cleaned up in the `webfactory/ssh-agent` post clean up. Implementing workaround as in webfactory/ssh-agent#184
I also have this issue, any news? |
This is causing problems here too. It'd be great to have a resolution if one is available. |
Thanks @kcarlson, your work around did the trick.
I'm wondering if this should be cleaning up the global gitconfig but is failing. |
The modified git config is not cleaned up after a run, e.g. the
url git@key-
section.This will affect a subsequent run on, for example, a self-hosted runner.
We are using a workaround which may help someone:
The text was updated successfully, but these errors were encountered: