Fix a potential security leak with ssh private keys and ignore empty keys #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you confirm that in fact no private key data is written to logs? |
|
Oh! You're right, I totally missed it. It's the public key that was written to logs, not the private key! 🤦🏻 I confirm that in fact no private key is written to logs. I will close this pull request since no modifications are required! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fix a potential security leak in workflow logs when the private key is not a GitHub deployment key.
Instead of writing the entire private key in logs, the zero based position of the key in the provided list is now outputted.
At the same time, I tweaked the flow to ignore empty keys before verifying if it's a GitHub deployment key!