Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please update webjar for blockly #1

Closed
n0mer opened this issue Oct 19, 2014 · 8 comments
Closed

please update webjar for blockly #1

n0mer opened this issue Oct 19, 2014 · 8 comments

Comments

@n0mer
Copy link

n0mer commented Oct 19, 2014

Hello,

currently version 1173 is available, which is definitely not the latest one.

Kindly asking for update.

Blockly has moved!
Home page is here:
https://developers.google.com/blockly/
Code repository is here:
https://github.com/google/blockly

@jamesward
Copy link
Member

The new repo doesn't have any tagged releases. I've filed an issue: google/blockly#4

We can use a git commit hash as the version if needed. Let me know what you think.

@n0mer
Copy link
Author

n0mer commented Oct 21, 2014

@jamesward , yes git commit hash would be awesome.

I'm really confused with google approach to "trunk"-only versioning :)

@n0mer
Copy link
Author

n0mer commented Oct 21, 2014

@jamesward, thank a ton!

By the way, i like your approach of "SNAPHOT" suffix. Probably, due to the nature of upstream project, better place for this blockly webjar artifact is in "snapshots" repository, with plain version like "BUILD-SNAPSHOT" (w/out any version information about upstream).

But anyway thanks for updating blockly, really appreciate that.

@jamesward
Copy link
Member

No problem.

The -SNAPSHOT thing is just a Maven convention. I haven't actually released a snapshot. (Although I could if needed.) The Maven release plugin removes the -SNAPSHOT and performs the actual release which should now be staged to sync with Maven Central.

@n0mer
Copy link
Author

n0mer commented Oct 21, 2014

indeed, and build tools like Ivy, Gradle and maven itself follows this convention.

I'm happy with the version that is currently published. Will ping you next day update will be required :)

@n0mer
Copy link
Author

n0mer commented Oct 21, 2014

and, just to let you know - 6909e38 is not showing as the "latest" @ webjars.org homepage

1171 alphanumerically is understood as the latest one.

@jamesward
Copy link
Member

Unfortunately it is going to be hard to tweak the sorting algorithm to support this. That is one of the downsides of an inconsistent upstream versioning system. If you want to take a stab it it the code is at: https://github.com/webjars/webjars/blob/master/app/models/WebJar.scala#L20

@n0mer
Copy link
Author

n0mer commented Oct 21, 2014

yes, this code is good for semantic versioning. thanks for sharing :)

jamesward pushed a commit that referenced this issue Jan 29, 2017
Merging latest updates for rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants