Skip to content

Open ReferenceExecutor for extending (#801) #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 29, 2021
Merged

Open ReferenceExecutor for extending (#801) #812

merged 2 commits into from
Mar 29, 2021

Conversation

spawnia
Copy link
Collaborator

@spawnia spawnia commented Mar 29, 2021

(cherry picked from commit c19cd7c)

@spawnia spawnia requested a review from simPod March 29, 2021 10:24
simPod
simPod reviewed Mar 29, 2021
View reviewed changes
Copy link
Collaborator

@simPod simPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fancy changes like this as it increases the scope where we have to worry about BC.

Though I have not investigated possible alternatives so can't offer a solution.

@spawnia
Copy link
Collaborator Author

spawnia commented Mar 29, 2021 •
edited
Loading

Methods or properties that are not marked with @api are not part of the BC guarantees. If someone wants to mess with internals, we should let them - but they are on their own when things go wrong.

@simPod
Copy link
Collaborator

simPod commented Mar 29, 2021

Aight so we can eventually revert this while not breaking BC promise. 🆗

@spawnia spawnia merged commit fe227f1 into 14.x Mar 29, 2021
@spawnia spawnia deleted the backport-801 branch March 29, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simPod simPod simPod left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spawnia @simPod @4n70w4