Fixes issue #133 with unicode strings #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadjohnston
changed the title
Current coverage is 98.21% (diff: 100%)
|
|
@sokra this looks good but I wonder if maybe these tests should be updated to reflect the same node versions as webpack/webpack. We can get back around to it if we need to, I'll assign to me to keep track. |
|
Thanks @TheLarkInn yep |
|
@sokra it would be awesome to get this on |
|
+1 on |
trevormunoz
added a commit
to trevormunoz/kap.js
that referenced
this pull request
Aug 25, 2016
This problem should go away after a new release of css-loader gets cut that includes css-selector-tokenizer >= 0.6.0 See webpack-contrib/css-loader#307
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#133