Skip to content

Conversation

bard
Copy link
Contributor

@bard bard commented Mar 7, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update
  • documentation fix

Motivation / Use-Case

Following the instructions at https://v4.webpack.js.org/loaders/expose-loader/ and then https://github.com/webpack-contrib/expose-loader/ leads to a non-functional configuration for v4 users and, unless one is familiar enough with WebPack APIs to interpret the error message, no clue why.

This small change should give a just-in-time heads-up.

Breaking Changes

None.

Additional Info

@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

Merging #128 (5067895) into master (3bd8e6e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #128   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files           4        4           
  Lines         129      129           
  Branches       41       41           
=======================================
  Hits          119      119           
  Misses          7        7           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bd8e6e...5067895. Read the comment docs.

@alexander-akait
Copy link
Member

Please accept CLA

@bard
Copy link
Contributor Author

bard commented Mar 9, 2021

@alexander-akait done. Note that no bot posted the link (as per https://github.com/webpack-contrib/expose-loader/blob/master/.github/CONTRIBUTING.md#contributor-license-agreement), I had to dig it out of CI checks.

@alexander-akait alexander-akait merged commit a7fef13 into webpack-contrib:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants