Skip to content

fix(package): config memory leak(s) #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2018
Merged

fix(package): config memory leak(s) #370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b02c71
chore(package): update `standard` v10.0.0...11.0.0 (`devDependencies`)
michael-ciniawsky Jul 10, 2018
3ff59fb
fix(package): config memory leak, updates `postcss-load-config` v1.2.…
michael-ciniawsky Jul 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ module.exports = function loader (css, map, meta) {

rc.ctx.webpack = this;

return postcssrc(rc.ctx, rc.path, { argv: false })
return postcssrc(rc.ctx, rc.path)
}).then((config) => {
if (!config) config = {}

Expand Down
31 changes: 8 additions & 23 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,16 @@
"version": "2.1.5",
"description": "PostCSS loader for webpack",
"main": "lib/index.js",
"engines": {
"node": ">= 4"
},
"files": [
"lib"
],
"engines": {
"node": ">= 4"
},
"dependencies": {
"loader-utils": "^1.1.0",
"postcss": "^6.0.0",
"postcss-load-config": "^1.2.0",
"postcss-load-config": "^2.0.0",
"schema-utils": "^0.4.0"
},
"devDependencies": {
Expand All @@ -21,34 +21,19 @@
"memory-fs": "^0.4.0",
"postcss-import": "^11.0.0",
"postcss-js": "^1.0.0",
"standard": "^10.0.0",
"standard": "^11.0.0",
"standard-version": "^4.0.0",
"sugarss": "^1.0.0",
"util.promisify": "^1.0.0",
"webpack": "^3.0.0"
},
"scripts": {
"clean": "rm -rf coverage test/outputs",
"lint": "standard",
"docs": "jsdoc2md lib/index.js > LOADER.md",
"postdocs": "npm run clean",
"pretest": "npm run clean",
"lint": "standard --env jest",
"test": "jest --verbose --coverage",
"docs": "jsdoc2md lib/index.js > LOADER.md",
"clean": "rm -rf coverage test/outputs",
"release": "standard-version"
},
"jest": {
"collectCoverageFrom": [
"lib/*.js"
]
},
"standard": {
"env": {
"jest": true
},
"ignore": [
"*.test.js"
]
},
"keywords": [
"css",
"postcss",
Expand Down