This repository was archived by the owner on Mar 17, 2021. It is now read-only.
Support for .JPG extension added to example web pack config
#133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
approved these changes
Jul 21, 2018
|
@jajaperson can you rebase PR? |
|
@evilebottnawi, to be honest, I don't know what that means 😂. I'm relatively new to this. Can you explain? |
|
@jajaperson fetch latest master branch and git rebase master |
|
@evilebottnawi Done that, sorry. Do I create a new pull request now, or is there a way to add it to this one? |
|
@jajaperson rebase master and force push or create new PR |
|
So... is it ready to be merged now?? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
In the example
webpack.config.js, the pattern/\.(png|jpg|gif)$/is used to select compatible images, but some images use.JPGinstead of.jpg, and are thus not detected by webpack.