Skip to content

Conversation

kroko
Copy link
Contributor

@kroko kroko commented Aug 12, 2020

Motivation / Use-Case

See #1161

added two examples for

  • only icss, no modules
  • both only icss, no modules and modules, sharing variables with both modules as well as JavaScript

see #1161

added two examples for
* only icss, no modules
* both only icss, no modules and modules, sharing variables with both modules as well as JavaScript
@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #1163 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1163   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files          10       10           
  Lines         627      627           
  Branches      197      197           
=======================================
  Hits          623      623           
  Misses          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33e7879...7690059. Read the comment docs.

@kroko
Copy link
Contributor Author

kroko commented Aug 12, 2020

@evilebottnawi did simplify. anything else?

fixed also `importLoaders` count
@kroko
Copy link
Contributor Author

kroko commented Aug 12, 2020

in last commit also fixed importLoaders count that was left incorrect after removing unnecessary loaders

@alexander-akait alexander-akait merged commit 8353353 into webpack:master Aug 14, 2020
@alexander-akait
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants