Skip to content

Conversation

billbalm
Copy link
Contributor

@billbalm billbalm commented Oct 6, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Just updating README example code to avoid people get ValidationError from copying those examples over.

@jsf-clabot
Copy link

jsf-clabot commented Oct 6, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@e5a9272). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1202   +/-   ##
=========================================
  Coverage          ?   99.40%           
=========================================
  Files             ?       11           
  Lines             ?      676           
  Branches          ?      217           
=========================================
  Hits              ?      672           
  Misses            ?        4           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5a9272...fd3315a. Read the comment docs.

alexander-akait
alexander-akait previously approved these changes Oct 6, 2020
@alexander-akait
Copy link
Member

@billbalm Can you fix conflicts?

@billbalm billbalm changed the title Fix example for localIdentContext in README docs: context is localIdentContext in README Oct 7, 2020
@billbalm
Copy link
Contributor Author

billbalm commented Oct 7, 2020

@billbalm Can you fix conflicts?

@evilebottnawi

Done. Please review again.

@alexander-akait alexander-akait merged commit 92fe103 into webpack:master Oct 7, 2020
@billbalm billbalm deleted the patch-1 branch October 16, 2020 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants