Skip to content

Conversation

skipjack
Copy link
Contributor

@skipjack skipjack commented Jun 2, 2017

What kind of change does this PR introduce?
readme fix

Did you add tests for your changes?
no

If relevant, did you update the README?
yes

Summary
cssnano.co/options/ is currently a 404 as it looks like they changed their routing
structure. This was throwing broken link errors on webpack.js.org as we dynamically
pull this readme.

Does this PR introduce a breaking change?
no

cssnano.co/options/ is currently a 404 as it looks like they changed their routing
structure. This was throwing broken link errors on webpack.js.org as we dynamically
pull this readme.
@codecov
Copy link

codecov bot commented Jun 2, 2017

Codecov Report

Merging #550 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #550   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          10       10           
  Lines         367      367           
  Branches       87       87           
=======================================
  Hits          362      362           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec4006c...2f234fb. Read the comment docs.

@michael-ciniawsky michael-ciniawsky changed the title docs(readme): fix broken link docs(README): fix broken link Jun 2, 2017

In some cases the minification is destructive to the css, so you can provide your own options to the minifier if needed. cssnano is used for minification and you find a [list of options here](http://cssnano.co/options/).
In some cases the minification is destructive to the css, so you can provide your own options to the cssnano-based minifier if needed. See [cssnano's documenation](http://cssnano.co/guides/) for more information on the available options.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documenation => documentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah good catch

@michael-ciniawsky michael-ciniawsky added this to the 0.28.4 milestone Jun 2, 2017
@michael-ciniawsky michael-ciniawsky merged commit c2e0934 into webpack:master Jun 2, 2017
@michael-ciniawsky michael-ciniawsky modified the milestone: 0.28.6 Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants