Skip to content

fix: safe checking if params are present for at rule #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 14, 2018
Merged

fix: safe checking if params are present for at rule #871

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31380e0
Safe checking if params are present
Antonio-Laguna Dec 14, 2018
9d0c096
Fixing eslint
Antonio-Laguna Dec 14, 2018
2bfb0b5
Adding comment to if rule
Antonio-Laguna Dec 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/plugins/postcss-icss-parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,12 @@ export default postcss.plugin(

// Replace tokens in at-rules
css.walkAtRules((atrule) => {
// eslint-disable-next-line no-param-reassign
atrule.params = replaceImportsInString(atrule.params.toString());
// Due reusing `ast` from `postcss-loader` some plugins may lack
// `params` property, we need to account for this possibility
if (atrule.params) {
// eslint-disable-next-line no-param-reassign
atrule.params = replaceImportsInString(atrule.params.toString());
}
});

// Replace tokens in export
Expand Down