Skip to content

Conversation

krfisc88
Copy link
Contributor

@krfisc88 krfisc88 commented Jan 4, 2021

Comment regarding use of spread operator to extend existing minimizers lacked a comma causing syntax errors

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

To prevent future noobs from struggling with extending existing minimizers, I have added a comma to the comment.

Breaking Changes

Additional Info

Comment regarding use of spread operator to extend existing minimizers lacked a comma causing syntax errors
@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #49 (822d001) into master (2afc01b) will decrease coverage by 8.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   97.58%   89.51%   -8.07%     
==========================================
  Files           5        5              
  Lines         248      248              
  Branches       93       93              
==========================================
- Hits          242      222      -20     
- Misses          5       23      +18     
- Partials        1        3       +2     
Impacted Files Coverage Δ
src/Webpack5Cache.js 0.00% <0.00%> (-100.00%) ⬇️
src/index.js 91.71% <0.00%> (-5.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2afc01b...822d001. Read the comment docs.

@alexander-akait alexander-akait merged commit 66c054f into webpack:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants