Skip to content

Conversation

thomasmichaelwallace
Copy link
Contributor

Drops node engine version down, and confirms build/test against node 6.9.0.

This resolves issue #141, which in-turn will enable webpack/webpack#6579 to be resolved.

@jsf-clabot
Copy link

jsf-clabot commented Mar 26, 2018

CLA assistant check
All committers have signed the CLA.

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@codecov
Copy link

codecov bot commented Mar 26, 2018

Codecov Report

Merging #142 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   92.57%   92.57%           
=======================================
  Files          37       37           
  Lines        1454     1454           
  Branches      336      336           
=======================================
  Hits         1346     1346           
  Misses        108      108

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42ff594...30ecaf7. Read the comment docs.

@ooflorent
Copy link
Member

Thanks!

@ooflorent ooflorent merged commit 6573e8d into webpack:master Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants