chore: remove Node.js 4, add Node.js 10 #128
Conversation
|
|
| webpack_version: latest | ||
| job_part: test | ||
| - nodejs_version: '4.3' | ||
| - nodejs_version: '6' |
There was a problem hiding this comment.
Don't remove node@4, it will be remove when we drop node@4 support, just add node@10
There was a problem hiding this comment.
Sure? See the last commits and the failing test suite. The dependencies require node >= 6.
There was a problem hiding this comment.
| env: WEBPACK_VERSION=canary JOB_PART=test | ||
| before_install: | ||
| - 'if [[ `npm -v` != 5* ]]; then npm i -g npm@^5.0.0; fi' | ||
| - npm i -g npm@latest |
There was a problem hiding this comment.
npm@6 don't support node 4 left this as is
There was a problem hiding this comment.
node 4 is EOL and fails (see the failing unit tests of the last commits in the master branch).
|
We can not test further before this is not fixed: #129 Not sure where the config for CircleCI is and how it is currently configured but it seems it is not correctly working. |
|
@DanielRuf should be works now, can you rebase? |
|
Thanks for the update. Will do so later today. |
So basically these files are not there anymore so I close this PR. |
No description provided.