Add support for ES2015 module syntax #433
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Please add tests. |
@hiroppy I actually wanted to add a test for this, but the current test suite seems broken in master. I checked other PRs, and they weren't including tests in new features. I tested manually and it's doing what it's supposed to do. |
|
@evilebottnawi tests added, please review at your convenience :) |
|
Need do same for |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Using the CommonJS module syntax prevents Webpack optimization features from running (tree shaking, module concatenation).
Issue #424
Breaking Changes
Default is to use the old syntax, so no
Additional Info