Skip to content

Conversation

snitin315
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

For webpack/webpack.js.org#3776

Refers webpack/webpack.js.org#3776 (comment)

Breaking Changes

Additional Info

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #539 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #539   +/-   ##
=======================================
  Coverage   88.49%   88.49%           
=======================================
  Files           5        5           
  Lines         426      426           
  Branches       94       94           
=======================================
  Hits          377      377           
  Misses         47       47           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b21c137...ec687dd. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@EugeneHlushko
Copy link
Member

@evilebottnawi This should be safe to merge regardless right?

@alexander-akait
Copy link
Member

@EugeneHlushko yes, I will fix CI tomorrow and do merge

@alexander-akait alexander-akait merged commit 6efb133 into webpack:master Jun 18, 2020
@alexander-akait
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants