Skip to content

fix: compatibility with webpack@4 and webpack@5 for monorepos #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2020
Merged

fix: compatibility with webpack@4 and webpack@5 for monorepos #636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ const {
util: { createHash },
} = webpack;

const isWebpack4 = webpackVersion[0] === '4';

const pluginName = 'mini-css-extract-plugin';

const REGEXP_CHUNKHASH = /\[chunkhash(?::(\d+))?\]/i;
Expand Down Expand Up @@ -97,16 +95,12 @@ class MiniCssExtractPlugin {
this.options.chunkFilename = '[id].css';
}
}

if (!isWebpack4 && 'hmr' in this.options) {
throw new Error(
"The 'hmr' option doesn't exist for the mini-css-extract-plugin when using webpack 5 (it's automatically determined)"
);
}
}

/** @param {import("webpack").Compiler} compiler */
apply(compiler) {
const isWebpack4 = compiler.webpack ? false : webpackVersion[0] === '4';

if (!isWebpack4) {
const { splitChunks } = compiler.options.optimization;
if (splitChunks) {
Expand Down Expand Up @@ -200,7 +194,9 @@ class MiniCssExtractPlugin {

// We don't need hot update chunks for css
// We will use the real asset instead to update
if (chunk instanceof webpack.HotUpdateChunk) return;
if (chunk instanceof webpack.HotUpdateChunk) {
return;
}

const renderedModules = Array.from(
this.getChunkModules(chunk, chunkGraph)
Expand Down Expand Up @@ -439,7 +435,10 @@ class MiniCssExtractPlugin {
} else {
const enabledChunks = new WeakSet();
const handler = (chunk, set) => {
if (enabledChunks.has(chunk)) return;
if (enabledChunks.has(chunk)) {
return;
}

enabledChunks.add(chunk);

// eslint-disable-next-line global-require
Expand Down
4 changes: 2 additions & 2 deletions src/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ import schema from './loader-options.json';

const pluginName = 'mini-css-extract-plugin';

const isWebpack4 = webpackVersion[0] === '4';

function hotLoader(content, context) {
const accept = context.locals
? ''
Expand Down Expand Up @@ -105,6 +103,8 @@ export function pitch(request) {

let source;

const isWebpack4 = childCompiler.webpack ? false : webpackVersion[0] === '4';

if (isWebpack4) {
childCompiler.hooks.afterCompile.tap(pluginName, (compilation) => {
source =
Expand Down