Skip to content

fix: yarn pnp compatibility #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2021
Merged

fix: yarn pnp compatibility #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,20 @@ const REGEXP_CONTENTHASH = /\[contenthash(?::(\d+))?\]/i;
const REGEXP_NAME = /\[name\]/i;
const DEFAULT_FILENAME = '[name].css';

if (webpack.util.serialization && webpack.util.serialization.registerLoader) {
const pathLength = `${pluginName}/dist`.length;

webpack.util.serialization.registerLoader(
/^mini-css-extract-plugin\//,
(request) => {
// eslint-disable-next-line global-require, import/no-dynamic-require
require(`.${request.slice(pathLength)}`);

return true;
}
);
}

class MiniCssExtractPlugin {
constructor(options = {}) {
validate(schema, options, {
Expand Down
75 changes: 0 additions & 75 deletions test/TestCache.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,6 @@ describe('TestCache', () => {

it('should work without cache', async () => {
if (webpack.version[0] !== '4') {
const originalRegister = webpack.util.serialization.register;

webpack.util.serialization.register = jest
.fn()
.mockImplementation((...args) => {
if (args[1].startsWith('mini-css-extract-plugin')) {
// eslint-disable-next-line no-param-reassign
args[1] = args[1].replace(/dist/, 'src');

return originalRegister(...args);
}

return originalRegister(...args);
});

const casesDirectory = path.resolve(__dirname, 'cases');
const directoryForCase = path.resolve(casesDirectory, 'asset-modules');
// eslint-disable-next-line import/no-dynamic-require, global-require
Expand Down Expand Up @@ -136,21 +121,6 @@ describe('TestCache', () => {

it('should work with the "memory" cache', async () => {
if (webpack.version[0] !== '4') {
const originalRegister = webpack.util.serialization.register;

webpack.util.serialization.register = jest
.fn()
.mockImplementation((...args) => {
if (args[1].startsWith('mini-css-extract-plugin')) {
// eslint-disable-next-line no-param-reassign
args[1] = args[1].replace(/dist/, 'src');

return originalRegister(...args);
}

return originalRegister(...args);
});

const casesDirectory = path.resolve(__dirname, 'cases');
const directoryForCase = path.resolve(casesDirectory, 'asset-modules');
// eslint-disable-next-line import/no-dynamic-require, global-require
Expand Down Expand Up @@ -262,21 +232,6 @@ describe('TestCache', () => {

it('should work with the "filesystem" cache', async () => {
if (webpack.version[0] !== '4') {
const originalRegister = webpack.util.serialization.register;

webpack.util.serialization.register = jest
.fn()
.mockImplementation((...args) => {
if (args[1].startsWith('mini-css-extract-plugin')) {
// eslint-disable-next-line no-param-reassign
args[1] = args[1].replace(/dist/, 'src');

return originalRegister(...args);
}

return originalRegister(...args);
});

const casesDirectory = path.resolve(__dirname, 'cases');
const directoryForCase = path.resolve(casesDirectory, 'simple');
// eslint-disable-next-line import/no-dynamic-require, global-require
Expand Down Expand Up @@ -392,21 +347,6 @@ describe('TestCache', () => {

it('should work with the "filesystem" cache and asset modules', async () => {
if (webpack.version[0] !== '4') {
const originalRegister = webpack.util.serialization.register;

webpack.util.serialization.register = jest
.fn()
.mockImplementation((...args) => {
if (args[1].startsWith('mini-css-extract-plugin')) {
// eslint-disable-next-line no-param-reassign
args[1] = args[1].replace(/dist/, 'src');

return originalRegister(...args);
}

return originalRegister(...args);
});

const casesDirectory = path.resolve(__dirname, 'cases');
const directoryForCase = path.resolve(casesDirectory, 'asset-modules');
// eslint-disable-next-line import/no-dynamic-require, global-require
Expand Down Expand Up @@ -528,21 +468,6 @@ describe('TestCache', () => {

it('should work with the "filesystem" cache and file-loader', async () => {
if (webpack.version[0] !== '4') {
const originalRegister = webpack.util.serialization.register;

webpack.util.serialization.register = jest
.fn()
.mockImplementation((...args) => {
if (args[1].startsWith('mini-css-extract-plugin')) {
// eslint-disable-next-line no-param-reassign
args[1] = args[1].replace(/dist/, 'src');

return originalRegister(...args);
}

return originalRegister(...args);
});

const casesDirectory = path.resolve(__dirname, 'cases');
const directoryForCase = path.resolve(casesDirectory, 'file-loader');
// eslint-disable-next-line import/no-dynamic-require, global-require
Expand Down