Skip to content

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #873

Breaking Changes

No

Additional Info

There is limitation - hash is xxxxx, because we don't know hash at this stage, we are building modules and hash calculation is impossible right now

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #881 (b36bb40) into master (0651fa5) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #881      +/-   ##
==========================================
+ Coverage   91.28%   91.32%   +0.03%     
==========================================
  Files           6        6              
  Lines         792      795       +3     
  Branches      214      216       +2     
==========================================
+ Hits          723      726       +3     
  Misses         63       63              
  Partials        6        6              
Impacted Files Coverage Δ
src/loader.js 90.00% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0651fa5...b36bb40. Read the comment docs.

@alexander-akait alexander-akait merged commit 41bd828 into master Dec 15, 2021
@alexander-akait alexander-akait deleted the fix-crash-when-public-path-as-function branch December 15, 2021 13:26
@roland-reed
Copy link

roland-reed commented Jan 5, 2022

When will new version containing this fix be published? It seems that this PR has been merged over 20 days but no new version is published 😂 @alexander-akait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: publicPath.replace is not a function when output.publicPath of webpack config is a function

2 participants