Skip to content

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Jul 20, 2024

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

These are a number of small grammar issues I noticed while working on #1211 which I figured I'd do a dedicated PR for - these are not Strictly Better and there are still some improvements that could be made, but they feel like a good start :)

Breaking Changes

This is not a breaking change

Additional Info

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ver nice, thanks a lot ✨ Left a small comment

@G-Rath G-Rath requested a review from evenstensberg July 20, 2024 21:11
Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more tweaks and I think we are good to approve this!

@G-Rath G-Rath requested a review from evenstensberg July 20, 2024 21:25
Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thx & congrats on your first contribution!🌟

@G-Rath
Copy link
Contributor Author

G-Rath commented Jul 20, 2024

Looks like CI is failing due to sass/node-sass#3420 and that it might not get fixed in favor of officially marked as unmaintained 🤔

@evenstensberg
Copy link
Member

This is just a docs change, so we'll merge anyway

@evenstensberg evenstensberg merged commit f2467ac into webpack:master Jul 20, 2024
@G-Rath G-Rath deleted the improve-readme branch July 20, 2024 22:46
@G-Rath
Copy link
Contributor Author

G-Rath commented Jul 20, 2024

cool, thanks - I'll see if this can be worked around in the meantime by just installing a different version of Python in CI, which'll be easier now that I'm no longer a first-time contributor 🎉

@evenstensberg
Copy link
Member

Awesome,good stuff 🙏

@G-Rath
Copy link
Contributor Author

G-Rath commented Jul 21, 2024

Have opened #1215 to fix the node-sass issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants