Skip to content

[WIP] refactor(loader): v7.0.0 #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[WIP] refactor(loader): v7.0.0 #514

wants to merge 3 commits into from

Conversation

joshwiens
Copy link
Member

@joshwiens joshwiens commented Dec 5, 2017 •
edited
Loading

  • Fixes for Webpack 4.x
  • Drops support for NodeJS 4.x
  • Sets minimum peerDep to Webpack 3.x

BREAKING CHANGE: Sets engines to "node": ">= 6.9.0 || >= 8.9.0"
BREAKING CHANGE: Drops support for Webpack v2.x

@joshwiens joshwiens changed the title [WIP] Sass Loader v7 [WIP] Sass Loader Webpack 4.x compatibility Dec 5, 2017
@codecov
Copy link

codecov bot commented Dec 5, 2017

Codecov Report

Merging #514 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #514   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files           6        6           
  Lines         117      117           
=======================================
  Hits          114      114           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b56d5...4d05bac. Read the comment docs.

@taneliang taneliang mentioned this pull request Feb 26, 2018
Closed
@KyleAMathews KyleAMathews mentioned this pull request Feb 27, 2018
Closed
@michael-ciniawsky michael-ciniawsky changed the title [WIP] Sass Loader Webpack 4.x compatibility [WIP] refactor(loader): v7.0.0 Feb 28, 2018
@michael-ciniawsky michael-ciniawsky added this to the 7.0.0 milestone Feb 28, 2018
@Timer Timer mentioned this pull request Mar 25, 2018
Merged
@BrodaNoel
Copy link

Hi there! Any news here? Looks like #533 is waiting for this one.

@Fabianopb
Copy link

@BrodaNoel and we have facebook/create-react-app#4195 waiting for #533! 😅

@jhnns jhnns closed this Apr 12, 2018
@jhnns jhnns deleted the next branch April 12, 2018 21:24
@jhnns jhnns restored the next branch April 12, 2018 21:25
@jhnns jhnns mentioned this pull request Apr 12, 2018
Merged
@jhnns jhnns deleted the next branch April 12, 2018 21:30
@michael-ciniawsky michael-ciniawsky removed this from the 8.0.0 milestone Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

semver: Major status: Pending type: Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joshwiens @BrodaNoel @Fabianopb @jhnns @michael-ciniawsky