Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant timeout definitions #1635

Merged
merged 4 commits into from
Jun 17, 2020
Merged

chore: remove redundant timeout definitions #1635

merged 4 commits into from
Jun 17, 2020

Conversation

rishabh3112
Copy link
Member

What kind of change does this PR introduce?
As we are now using default timeout of 120s for all the tests. Check jest.config.js for more info.
we can remove redundant timeout definitions in tests

Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
N/A
Summary
Same as above description

Does this PR introduce a breaking change?
No

Other information
No

@rishabh3112 rishabh3112 requested a review from a team as a code owner June 15, 2020 07:12
@webpack-bot
Copy link

@rishabh3112 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@snitin315 Please review the new changes.

@rishabh3112 rishabh3112 merged commit e445d4b into next Jun 17, 2020
@rishabh3112 rishabh3112 deleted the test/timeouts branch June 17, 2020 12:46
@jamesgeorge007 jamesgeorge007 changed the title chore: remove redundant timeout definations chore: remove redundant timeout definitions Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants