tests: remove --module-rules-options instances #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @webpack/cli-team, need to look at CI. |
|
@snitin315 problem on npm side https://status.npmjs.org/, don't worry |
evenstensberg
approved these changes
Aug 9, 2020
alexander-akait
approved these changes
Aug 10, 2020
| //--module-rules-options will be excluded for cli. | ||
| const moduleFlags = flagsFromCore.filter(({ name }) => name.startsWith('module-') && name !== 'module-rules-options'); | ||
|
|
||
| const moduleFlags = flagsFromCore.filter(({ name }) => name.startsWith('module-')); |
There was a problem hiding this comment.
/cc @snitin315 So we still don't have tests on module- flags?
There was a problem hiding this comment.
@evilebottnawi We have, This file contains exclusively tests for all module-* flags, We are extracting all the module-* flags here and then looping through them.
webpack-cli/test/core-flags/module-flags.test.js
Lines 8 to 9 in 4fe8045
This was referenced Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
tests
Did you add tests for your changes?
NA
If relevant, did you update the documentation?
NA
Summary
removed
--module-rules-optionsinstances as it has been excluded for cli from core schema.Does this PR introduce a breaking change?
NO
Other information
webpack/webpack#11171