Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli(init): fix init regexp #344

Merged
merged 2 commits into from
Mar 14, 2018
Merged

cli(init): fix init regexp #344

merged 2 commits into from
Mar 14, 2018

Conversation

evenstensberg
Copy link
Member

Fixes #343

@dhruvdutt
Copy link
Member

dhruvdutt commented Mar 13, 2018

@ev1stensberg Ah, I just did the same thing locally. Got a bit late pushing it. 😅

You'll also need to update this file as well.

test: new RegExp(/\.js$/),

Copy link
Member

@dhruvdutt dhruvdutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@webpack-bot
Copy link

@ev1stensberg Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@dhruvdutt Please review the new changes.

@evenstensberg evenstensberg merged commit bd68b18 into master Mar 14, 2018
dhruvdutt pushed a commit to dhruvdutt/webpack-cli that referenced this pull request Mar 14, 2018
* cli(init): fix init regexp

* cli(init): add literal quotes to module
@ematipico ematipico deleted the init-fix-regexp branch April 8, 2018 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants