cli(add): support for webpack config file #501
Conversation
| module.exports = function add(...args) { | ||
| const DEFAULT_WEBPACK_CONFIG_FILENAME = "webpack.config.js"; | ||
|
|
||
| const filePaths = args.slice(3); |
There was a problem hiding this comment.
Why are you slicing 3 here?
There was a problem hiding this comment.
Because first 3 args would be node path, webpack-cli path, add command.
4th item in the array would be everything after add command like the custom config path/name. So, we're slicing first three items to get the config path.
We can't directly use the last element of args because that would be "add" if the user doesn't mention any arg after add.
There was a problem hiding this comment.
Oki. let me check it out later to make sure its working 👍
packages/utils/resolve-packages.js
Outdated
| @@ -3,7 +3,7 @@ | |||
| const path = require("path"); | |||
| const chalk = require("chalk"); | |||
|
|
|||
| const modifyConfigHelper = require("./modify-config-helper"); | |||
| const modifyConfig = require("./modify-config-helper"); | |||
There was a problem hiding this comment.
don't see a reason to change this
There was a problem hiding this comment.
For consistency.
We're using modifyConfig everywhere across at codebase other than this place.
Please check this: https://github.com/webpack/webpack-cli/search?q=return+modifyHelper&unscoped_q=return+modifyHelper
There was a problem hiding this comment.
Use the previous convention 👍
There was a problem hiding this comment.
Updated all occurrences to use the previous convention.
|
🎉 This PR is included in version 3.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
No
If relevant, did you update the documentation?
Yes
Summary
Add support to specify webpack config file with args, default to webpack.config.js
webpack-cli add webpack.dev.jswebpack-cli addwebpack-cli add aaahha.jsSimilar usage for
update,remove.Does this PR introduce a breaking change?
No
Fixes #279