Skip to content

Conversation

sidharthachatterjee
Copy link
Contributor

What kind of change does this PR introduce?

Adds some tests

Did you add tests for your changes?

Yes

Summary

Gatsby uses webpack-dev-middleware and I wrote these tests while trying to debug gatsbyjs/gatsby#11348 so I figured I might as well contribute back

Please feel free to reject if this edge case is too specific

Does this PR introduce a breaking change?

No

Other information

@jsf-clabot
Copy link

jsf-clabot commented Jan 29, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #365 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #365   +/-   ##
=======================================
  Coverage   96.83%   96.83%           
=======================================
  Files           7        7           
  Lines         253      253           
=======================================
  Hits          245      245           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71c3e20...c93784f. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #365 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #365   +/-   ##
=======================================
  Coverage   96.83%   96.83%           
=======================================
  Files           7        7           
  Lines         253      253           
=======================================
  Hits          245      245           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71c3e20...c93784f. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pr

@alexander-akait alexander-akait merged commit c64a2c1 into webpack:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants