feat: allow Boolean type for the --firewall option (#3041)

webpack · Feb 24, 2021 · 6711c1d · 6711c1d
1 parent 7484be6
commit 6711c1d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -102,7 +102,8 @@ Options:
   --history-api-fallback     Fallback to /index.html for Single Page Applications.
   --compress                 Enable gzip compression.
   --public <value>           The public hostname/ip address of the server.
-  --firewall <value...>      Enable/disable firewall, or set hosts that are allowed to access the dev server.
+  --firewall [value...]      Enable firewall or set hosts that are allowed to access the dev server.
+  --no-firewall              Disable firewall.
 
 Global options:
   --color                    Enable colors on console.

diff --git a/bin/cli-flags.js b/bin/cli-flags.js
@@ -118,10 +118,12 @@ module.exports = {
     },
     {
       name: 'firewall',
-      type: String,
+      type: [String, Boolean],
       description:
-        'Enable/disable firewall, or set hosts that are allowed to access the dev server.',
+        'Enable firewall or set hosts that are allowed to access the dev server.',
+      negatedDescription: 'Disable firewall.',
       multiple: true,
+      negative: true,
     },
   ],
 };