Skip to content

Commit

Permalink
fix: regression with port and bonjour
Browse files Browse the repository at this point in the history
  • Loading branch information
alexander-akait committed May 6, 2021
1 parent f2f335c commit c2805fe
Show file tree
Hide file tree
Showing 5 changed files with 68 additions and 70 deletions.
2 changes: 1 addition & 1 deletion lib/Server.js
Expand Up @@ -766,7 +766,7 @@ class Server {
findPort(port || this.options.port)
// eslint-disable-next-line no-shadow
.then((port) => {
this.port = port;
this.options.port = port;

return this.server.listen(port, this.hostname, (error) => {
if (this.options.hot || this.options.liveReload) {
Expand Down
130 changes: 64 additions & 66 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -105,7 +105,7 @@
"typescript": "^4.2.4",
"url-loader": "^4.1.1",
"webpack": "^5.36.2",
"webpack-cli": "^4.6.0",
"webpack-cli": "^4.7.0",
"webpack-merge": "^5.7.3"
},
"peerDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion test/cli/__snapshots__/cli.test.js.snap.webpack4
Expand Up @@ -173,7 +173,7 @@ exports[`CLI https options 1`] = `
`;

exports[`CLI should generate correct cli flags 1`] = `
"Usage: webpack serve|s [entries...] [options]
"Usage: webpack serve|server|s [entries...] [options]

Run the webpack dev server.

Expand Down
2 changes: 1 addition & 1 deletion test/cli/__snapshots__/cli.test.js.snap.webpack5
Expand Up @@ -173,7 +173,7 @@ exports[`CLI https options 1`] = `
`;

exports[`CLI should generate correct cli flags 1`] = `
"Usage: webpack serve|s [entries...] [options]
"Usage: webpack serve|server|s [entries...] [options]

Run the webpack dev server.

Expand Down

0 comments on commit c2805fe

Please sign in to comment.